Files
Containr/app/backend/internal/database/goose_migrations.go
Tomas Dvorak 9e3aa3aa17 Consolidate backend: drop vendored APwhy, converge on goose + sqlc
Phase 0 cleanup verified end-to-end:

- Delete vendored APwhy runtime (cmd/apwhy, internal/apwhy) and the
  unwired copy (internal/api/server.go + static bundle + cloned
  internal/{storage,analytics,auth,rbac}) — ~7.5k lines of dead code.
- Keep Containr's native internal/gateway; move APwhy management
  routes under /api/v1/gateway/* so they stop colliding with the
  native /services paths. Fix handlers against the real schema:
  UUID ids via RETURNING, integer enabled flags, plan validation,
  service validate endpoint, unique-violation mapping.
- Port agents.go off GORM onto sqlc (sqlc/queries/agents.sql);
  drop gorm dependencies; fix sqlc schema drift (services.environment_id).
- Replace the SELECT 1 goose baseline with the real consolidated
  schema (52 tables) minus APwhy's parallel auth/RBAC objects;
  idempotent via IF NOT EXISTS / OR REPLACE / guarded DO blocks so it
  replays cleanly over legacy installs. Add a drop migration for the
  dead objects and delete the legacy filename-tracked migrations/
  loader, directory, and Dockerfile copy. Verified via cmd/migrate:
  fresh install 53 tables, legacy upgrade clean to 20260917000000.
- Canvas: add invisible React Flow handles to ServiceNode so inferred
  auto-connections stop emitting warning #008.
- Remove reactflow dep (superseded by @xyflow/react), test harness
  cmds, and legacy 0001_init.sql backups.

Authored By: TDvorak <[email protected]>
2026-09-17 09:40:08 +02:00

128 lines
3.4 KiB
Go

package database
import (
"context"
"fmt"
"log"
"os"
"time"
"github.com/pressly/goose/v3"
)
const (
defaultGooseMigrationsDir = "migrations_goose"
migrationAdvisoryLockKey = int64(637266846588921720)
)
var migrationLockRetryInterval = 250 * time.Millisecond
// MigrateAll runs the goose-managed migrations. goose is the only migration
// path; the legacy filename-tracked system was consolidated into the baseline.
func (db *DB) MigrateAll(gooseDir string) error {
ctx, cancel := context.WithTimeout(context.Background(), 2*time.Minute)
defer cancel()
return db.MigrateAllWithLock(ctx, gooseDir)
}
// MigrateAllWithLock runs goose migrations while holding a PostgreSQL
// advisory lock to prevent concurrent migrators from racing.
func (db *DB) MigrateAllWithLock(ctx context.Context, gooseDir string) error {
if gooseDir == "" {
gooseDir = defaultGooseMigrationsDir
}
releaseLock, err := db.acquireMigrationLock(ctx)
if err != nil {
return err
}
defer func() {
if unlockErr := releaseLock(); unlockErr != nil {
log.Printf("Warning: failed to release migration advisory lock: %v", unlockErr)
}
}()
return db.MigrateGoose(gooseDir)
}
func (db *DB) acquireMigrationLock(ctx context.Context) (func() error, error) {
if ctx == nil {
ctx = context.Background()
}
conn, err := db.Conn(ctx)
if err != nil {
return nil, fmt.Errorf("failed to open connection for migration lock: %w", err)
}
for {
var acquired bool
if err := conn.QueryRowContext(ctx, "SELECT pg_try_advisory_lock($1)", migrationAdvisoryLockKey).Scan(&acquired); err != nil {
conn.Close()
return nil, fmt.Errorf("failed to acquire migration advisory lock: %w", err)
}
if acquired {
break
}
select {
case <-ctx.Done():
conn.Close()
return nil, fmt.Errorf("timed out waiting for migration advisory lock: %w", ctx.Err())
case <-time.After(migrationLockRetryInterval):
}
}
log.Println("Acquired migration advisory lock")
return func() error {
defer conn.Close()
var released bool
if err := conn.QueryRowContext(context.Background(), "SELECT pg_advisory_unlock($1)", migrationAdvisoryLockKey).Scan(&released); err != nil {
return fmt.Errorf("failed to release migration advisory lock: %w", err)
}
if !released {
return fmt.Errorf("migration advisory lock was not held by current session")
}
log.Println("Released migration advisory lock")
return nil
}, nil
}
func (db *DB) MigrateGoose(migrationsDir string) error {
if _, err := os.Stat(migrationsDir); err != nil {
if os.IsNotExist(err) {
log.Printf("Goose migrations directory %q not found, skipping goose migrations", migrationsDir)
return nil
}
return fmt.Errorf("failed to access goose migrations directory %q: %w", migrationsDir, err)
}
if err := db.ensureRequiredExtensions(); err != nil {
return err
}
if err := goose.SetDialect("postgres"); err != nil {
return fmt.Errorf("failed to set goose dialect: %w", err)
}
if err := goose.Up(db.DB, migrationsDir); err != nil {
return fmt.Errorf("failed to run goose migrations from %q: %w", migrationsDir, err)
}
log.Printf("Goose migrations completed successfully from %q", migrationsDir)
return nil
}
func (db *DB) GooseStatus(migrationsDir string) error {
if err := goose.SetDialect("postgres"); err != nil {
return fmt.Errorf("failed to set goose dialect: %w", err)
}
if err := goose.Status(db.DB, migrationsDir); err != nil {
return fmt.Errorf("failed to get goose migration status: %w", err)
}
return nil
}