From 40c189c4312d1690f7930c7ae050158da1eb680c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tom=C3=A1=C5=A1=20Dvo=C5=99=C3=A1k?=
 <150935816+Dvorinka@users.noreply.github.com>
Date: Mon, 28 Sep 2026 21:39:54 +0200
Subject: [PATCH] fix(install): stop exec from silencing the tty prompt (#47)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

exec 9</dev/tty 2>/dev/null inside the if condition redirected the whole
shell's stderr to /dev/null permanently — the read -p prompt then wrote
into the void, leaving the installer blocked on an invisible question.
Replace with a plain </dev/tty redirect on read itself plus a quiet
true </dev/tty probe: the prompt displays, answers land, and no-tty
runs fall back to the default without error noise or the exec
redirect-failure shell-exit hazard.

Co-authored-by: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
---
 install.sh | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/install.sh b/install.sh
index 6a96da0..16e9c32 100755
--- a/install.sh
+++ b/install.sh
@@ -60,11 +60,13 @@ else
   if [ -z "$PUBLIC_URL" ]; then
     DEFAULT_URL="http://localhost"
     [ "$NGINX_PORT" != "80" ] && DEFAULT_URL="http://localhost:$NGINX_PORT"
-    # Under `curl | bash` stdin is the script pipe — prompt on the
-    # controlling terminal instead. No tty (CI/cron) → default silently.
-    if exec 9</dev/tty 2>/dev/null; then
-      read -rp "URL where you'll open Primora (domain or IP, e.g. https://primora.example.com) [$DEFAULT_URL]: " PUBLIC_URL <&9 || true
-      exec 9>&-
+    # Under `curl | bash` stdin is the script pipe — ask on the controlling
+    # terminal instead. `true </dev/tty` probes the open quietly; read's own
+    # redirect fails non-fatally (default applies) where there is no tty.
+    # Never `exec ... 2>/dev/null` here — exec redirections persist and would
+    # silence stderr, including the read prompt below, for the whole script.
+    if true 2>/dev/null </dev/tty; then
+      read -rp "URL where you'll open Primora (domain or IP, e.g. https://primora.example.com) [$DEFAULT_URL]: " PUBLIC_URL </dev/tty || true
     fi
     PUBLIC_URL="${PUBLIC_URL:-$DEFAULT_URL}"
   fi