mirror of
https://github.com/Dvorinka/Primora.git
synced 2026-10-28 15:51:23 +00:00
Tomas DvorakandDevin
55edbf8b56
Security:
- Graceful shutdown: http.Server + signal.NotifyContext, 10s drain,
retention sweeper cancelled before pool close
- Scoped API keys (migration 00006): ingest/read/write/admin enforced in
auth middleware; scope picker + badges in Settings UI; scopeless legacy
keys act as admin. Read-only keys now get 403 on ingest (verified live)
- nginx: baseline security headers on all responses, CSP scoped to SPA;
fixed add_header inheritance shadowing
- better-auth rate limit enabled unconditionally (was gated on NODE_ENV,
which the shipped .env sets to development)
- Mailpit moved to docker-compose.dev.yml; prod compose cannot expose it
- setup.sh generates PRIMORA_ENCRYPTION_KEY
Reliability/ops:
- Retention: per-project retention_{events,audit,webhook}_days
(migration 00007, 0=off) + hourly RetentionSweeper; edit UI in Projects
- GET /api/v1/metrics Prometheus exposition
- compose: healthchecks + restart policies everywhere, dragonfly pinned
to v2.0.0, depends_on service_healthy
- backup.sh/restore.sh (pg_dump -Fc + storage volume); restore verified
against scratch postgres+volume
- .dockerignore: exclude target dirs (build context was 4.7GB)
Correctness/testing:
- DBX transfer endpoint: POST /db-connections/:id/transfer — SQL or Redis
target, 1000-row bound, server-side creds (verified live pg→dragonfly)
- Pagination audit: ListComponents capped at 500 (auto-registers)
- CI: goose up/reset/up job + compose e2e-smoke job (smoke-e2e.sh
verified locally: signup, bootstrap, scoped keys, ingest, metrics)
- k6 load sanity script: 6650 reqs, ~217/s, 0 real failures, p95 221ms
(429s = configured rate limiter working)
Docs: DEPLOYMENT_GUIDE.md, PRODUCTION_READINESS.md; verify script
repaired (stale refs + set -e arithmetic abort). ROADMAP: phase 2 +
phase 6 marked complete.
Authored By: TDvorak <[email protected]>
Generated with [Devin](https://devin.ai)
Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
67 lines
2.3 KiB
Go
67 lines
2.3 KiB
Go
package middleware
|
|
|
|
import (
|
|
"net/http"
|
|
"testing"
|
|
|
|
"github.com/tdvorak/primora/apps/backend/internal/models"
|
|
)
|
|
|
|
func TestRequiredAPIKeyScope(t *testing.T) {
|
|
cases := []struct {
|
|
method, path, want string
|
|
}{
|
|
{http.MethodPost, "/api/v1/ingest", "ingest"},
|
|
{http.MethodOptions, "/api/v1/ingest", "read"}, // preflight passes through CORS
|
|
{http.MethodGet, "/api/v1/projects/x/events", "read"},
|
|
{http.MethodGet, "/api/v1/projects/x/api-keys", "read"},
|
|
{http.MethodPost, "/api/v1/projects/x/api-keys", "admin"},
|
|
{http.MethodDelete, "/api/v1/projects/x/api-keys/y", "admin"},
|
|
{http.MethodPatch, "/api/v1/projects/x/members/y", "admin"},
|
|
{http.MethodPatch, "/api/v1/projects/x", "admin"},
|
|
{http.MethodDelete, "/api/v1/projects/x", "admin"},
|
|
{http.MethodPatch, "/api/v1/organizations/x", "admin"},
|
|
{http.MethodDelete, "/api/v1/organizations/x", "admin"},
|
|
{http.MethodPost, "/api/v1/organizations/x/invitations", "admin"},
|
|
{http.MethodPost, "/api/v1/bootstrap", "admin"},
|
|
{http.MethodPost, "/api/v1/projects/x/buckets", "write"},
|
|
{http.MethodPost, "/api/v1/projects/x/db-connections/y/transfer", "write"},
|
|
{http.MethodDelete, "/api/v1/buckets/x", "write"},
|
|
{http.MethodPost, "/api/v1/projects/x/deploy-markers", "write"},
|
|
}
|
|
for _, tc := range cases {
|
|
if got := requiredAPIKeyScope(tc.method, tc.path); got != tc.want {
|
|
t.Errorf("%s %s: got %q, want %q", tc.method, tc.path, got, tc.want)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestActorHasScope(t *testing.T) {
|
|
key := func(scopes ...string) *models.Actor {
|
|
return &models.Actor{Type: models.ActorTypeAPIKey, Scopes: scopes}
|
|
}
|
|
user := &models.Actor{Type: models.ActorTypeUser}
|
|
|
|
if !user.HasScope("admin") {
|
|
t.Error("user actors bypass scope checks")
|
|
}
|
|
if !key("admin").HasScope("read") {
|
|
t.Error("admin should satisfy every requirement")
|
|
}
|
|
if !key("write").HasScope("read") || !key("write").HasScope("ingest") {
|
|
t.Error("write should imply read and ingest")
|
|
}
|
|
if key("write").HasScope("admin") {
|
|
t.Error("write must not imply admin")
|
|
}
|
|
if key("read").HasScope("write") || key("read").HasScope("ingest") {
|
|
t.Error("read must not imply write or ingest")
|
|
}
|
|
if !key("ingest").HasScope("ingest") || key("ingest").HasScope("read") {
|
|
t.Error("ingest keys only reach /ingest")
|
|
}
|
|
if key().HasScope("read") {
|
|
t.Error("scopeless key has no access")
|
|
}
|
|
}
|