mirror of
https://github.com/Dvorinka/Primora.git
synced 2026-10-28 15:51:23 +00:00
Tomas DvorakandDevin
2d6135121e
Stress-test remediation across MCP, CLI, and backend:
- primora_vault_exec rewritten as an allow-list (was deny-list):
colon-form single-token commands bypassed it, leaking every vault
secret; verbatim env-name injection allowed NODE_OPTIONS=--require
host RCE. Now fixed read-mostly command set, arg/path deny regex,
strict env-name grammar, loader-hook name blocklist. All prior
bypasses verified denied; allowed commands still inject.
- SSRF: webhook/job URL validation now blocks cloud metadata IPs
(169.254.169.254, fd00:ec2::254) inside the link-local allowance
and non-canonical IP encodings (decimal/hex bare hosts) smuggled
as "docker service names".
- Path params encodeURIComponent in all client consumers — encodeURI
left ?#& intact, smuggling query segments through {name} params.
- primora_upload_object strict-validates contentBase64 — Buffer.from
silently dropped invalid chars.
- MCP no-creds startup degrades instead of crashing mid-handshake.
- GET /api/v1/context — API-key self-discovery; fixes the CLI dead
end (login --api-key validates the key + seeds org/project,
use/context/whoami work under key auth).
- CLI: unknown commands / bare group exit 1 with hints; mri numeric
coercion reversed via raw-argv restore (007 stays "007");
login --json; orgs:rm / projects:rm / buckets:rm behind --yes;
fetch-failed errors name the cause.
- Error hygiene: pgx.ErrNoRows -> 404, pgconn codes -> clean
400/409 without SQLSTATE leaks, validator failures formatted,
services.InputError maps input faults to 400 (webhook URL/event
errors were 500s), presign on local driver -> 400.
- Webhook events accept wildcard patterns (*, ns.*, custom.*)
matched via SQL LIKE — client-published events can be webhooked.
Generated with [Devin](https://devin.ai)
Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
76 lines
2.2 KiB
TypeScript
76 lines
2.2 KiB
TypeScript
import { CreateBucketRequest, StorageService } from "@primora/api-client";
|
|
|
|
import { loadConfig } from "../config.js";
|
|
import { configureClient, requireAuth, requireProject, resolveBucketId } from "../http.js";
|
|
import { confirmOrAbort, isJson, printJson, printTable, success } from "../out.js";
|
|
|
|
export async function cmdBucketsList(options: {
|
|
project?: string;
|
|
q?: string;
|
|
json?: boolean;
|
|
}): Promise<void> {
|
|
const cfg = loadConfig();
|
|
requireAuth(cfg);
|
|
configureClient(cfg);
|
|
|
|
const projectId = requireProject(cfg, options.project);
|
|
const { items } = await StorageService.listBuckets({
|
|
projectId,
|
|
q: options.q || undefined,
|
|
});
|
|
if (isJson(options)) {
|
|
printJson(items);
|
|
return;
|
|
}
|
|
printTable(
|
|
["SLUG", "NAME", "VISIBILITY", "ID"],
|
|
items.map((b) => [b.slug, b.name, b.visibility, b.id]),
|
|
);
|
|
}
|
|
|
|
export async function cmdBucketsCreate(
|
|
name: string,
|
|
options: { project?: string; slug?: string; public?: boolean; json?: boolean },
|
|
): Promise<void> {
|
|
const cfg = loadConfig();
|
|
requireAuth(cfg);
|
|
configureClient(cfg);
|
|
|
|
const projectId = requireProject(cfg, options.project);
|
|
const slug = options.slug ?? name.toLowerCase().replace(/[^a-z0-9]+/g, "-").replace(/^-+|-+$/g, "");
|
|
const bucket = await StorageService.createBucket({
|
|
projectId,
|
|
requestBody: {
|
|
name,
|
|
slug,
|
|
visibility: options.public
|
|
? CreateBucketRequest.visibility.PUBLIC
|
|
: CreateBucketRequest.visibility.PRIVATE,
|
|
},
|
|
});
|
|
if (isJson(options)) {
|
|
printJson(bucket);
|
|
return;
|
|
}
|
|
success(`Bucket "${bucket.name}" created (${bucket.slug}, ${bucket.visibility})`);
|
|
}
|
|
|
|
export async function cmdBucketsRemove(
|
|
bucketRef: string,
|
|
options: { project?: string; yes?: boolean; json?: boolean },
|
|
): Promise<void> {
|
|
const cfg = loadConfig();
|
|
requireAuth(cfg);
|
|
configureClient(cfg);
|
|
|
|
const projectId = requireProject(cfg, options.project);
|
|
const bucketId = await resolveBucketId(projectId, bucketRef);
|
|
await confirmOrAbort(`Delete bucket "${bucketRef}" and all its objects?`, options.yes);
|
|
await StorageService.deleteBucket({ bucketId });
|
|
if (isJson(options)) {
|
|
printJson({ deleted: bucketId });
|
|
} else {
|
|
success(`deleted bucket ${bucketRef}`);
|
|
}
|
|
}
|